[webkit-reviews] review granted: [Bug 199601] JSGlobalObject type macros should support feature flags and WeakRef should have one : [Attachment 374152] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 199601: JSGlobalObject type macros should support feature flags and WeakRef
should have one
https://bugs.webkit.org/show_bug.cgi?id=199601

Attachment 374152: Patch

https://bugs.webkit.org/attachment.cgi?id=374152&action=review




--- Comment #14 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 374152
  --> https://bugs.webkit.org/attachment.cgi?id=374152
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374152&action=review

r=me

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:721
> +#define CREATE_PROTOTYPE_FOR_LAZY_TYPE(capitalName, lowerName, properName,
instanceType, jsName, prototypeBase, featureFlag) if (featureFlag) \

nit: I think you should add the { } since the body is a multi-line statement.