[webkit-reviews] review granted: [Bug 199806] [Text autosizing] [iPadOS] Product label text is clipped in portrait mode on the front page of sephora.com : [Attachment 374165] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Wenson Hsieh <wenson_hsieh at apple.com>'s
request for review:
Bug 199806: [Text autosizing] [iPadOS] Product label text is clipped in
portrait mode on the front page of sephora.com
https://bugs.webkit.org/show_bug.cgi?id=199806

Attachment 374165: Patch

https://bugs.webkit.org/attachment.cgi?id=374165&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 374165
  --> https://bugs.webkit.org/attachment.cgi?id=374165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374165&action=review

> Source/WebCore/rendering/style/TextSizeAdjustment.cpp:56
> +	   Length heightOrMaxHeightAsLength;

Optional<Length> instead of checking Length.isAuto() might reflect the logic
better.

> Source/WebCore/rendering/style/TextSizeAdjustment.cpp:74
> +	   return approximateNumberOfLines < 6 && approximateNumberOfLines -
std::floor(approximateNumberOfLines) < 0.01;

Could you name the constant values please? It improves code readability (and
works as comment too).