[webkit-reviews] review granted: [Bug 199587] Typing into a cell in a Google Sheet lags behind by one character : [Attachment 373974] Patch and layout test

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 199587: Typing into a cell in a Google Sheet lags behind by one character
https://bugs.webkit.org/show_bug.cgi?id=199587

Attachment 373974: Patch and layout test

https://bugs.webkit.org/attachment.cgi?id=373974&action=review




--- Comment #20 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 373974
  --> https://bugs.webkit.org/attachment.cgi?id=373974
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=373974&action=review

This seems like a reasonable approach to this issue. I'm not sure if we should
open this up for 'stash' as well (who suffers from the same issue). We may find
that many sites need this quirk (or maybe this quirk needs to be standard
behavior).

> Source/WebCore/ChangeLog:14
> +	   of the document.

Was the timeout supposed to wait for the longest timeout registered on the
page?

> Source/WebCore/page/Quirks.cpp:362
> +    return equalLettersIgnoringASCIICase(url.host(), "docs.google.com") &&
url.path().startsWithIgnoringASCIICase("/spreadsheets/");

Should we do this for stash, too?