[webkit-reviews] review granted: [Bug 199650] Keyword lookup can use memcmp to get around unaligned load undefined behavior : [Attachment 373806] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saagar Jha
<saagarjha at apple.com>'s request for review:
Bug 199650: Keyword lookup can use memcmp to get around unaligned load
undefined behavior
https://bugs.webkit.org/show_bug.cgi?id=199650

Attachment 373806: Patch

https://bugs.webkit.org/attachment.cgi?id=373806&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 373806
  --> https://bugs.webkit.org/attachment.cgi?id=373806
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373806&action=review

r=me with nit.

> Source/JavaScriptCore/KeywordLookupGenerator.py:170
> +		       needle = "(Char []){" + ", ".join(["'%s'" % (c) for c in
test]) + "}"

Can you change it to "static_cast" instead of C-style cast?