[webkit-reviews] review denied: [Bug 199764] Make WKURLSchemeTask thread safe : [Attachment 374047] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 199764: Make WKURLSchemeTask thread safe
https://bugs.webkit.org/show_bug.cgi?id=199764

Attachment 374047: Patch

https://bugs.webkit.org/attachment.cgi?id=374047&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 374047
  --> https://bugs.webkit.org/attachment.cgi?id=374047
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374047&action=review

>> Source/WTF/wtf/MainThread.cpp:179
>> +	RunLoop
> 
> I don't understand the distinction you're making between Thread and RunLoop
here. There's one RunLoop per thread, so what is the actual difference here?

This is to not cause problems with UIWebView web thread stuff.

>> Source/WTF/wtf/MainThread.cpp:185
>>	    function();
> 
> isMainThread() is true on the WebThread, even when isMainRunLoop() is false.
This seems like a bug.

You're right.  This should be isMainRunLoop when mainStyle is RunLoop.