[webkit-reviews] review granted: [Bug 199764] Make WKURLSchemeTask thread safe : [Attachment 374047] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 15 10:23:52 PDT 2019

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 199764: Make WKURLSchemeTask thread safe

Attachment 374047: Patch


--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 374047
  --> https://bugs.webkit.org/attachment.cgi?id=374047

View in context: https://bugs.webkit.org/attachment.cgi?id=374047&action=review

> Source/WTF/wtf/MainThread.cpp:177
> +enum class MainStyle {

There's no reason not to have : bool here.  I think it's good practice, even if
we don't store this anywhere yet.

> Source/WTF/wtf/MainThread.cpp:182
> +static void callOnMainAndWait(WTF::Function<void()>&& function, MainStyle

WTF:: unnecessary many places in this patch.

> Source/WebKit/UIProcess/API/Cocoa/WKURLSchemeTask.mm:37
> +static WebKit::WebURLSchemeTask::ExceptionType
onType ()>&& function)

Extra space, WTF:: unnecessary

More information about the webkit-reviews mailing list