[webkit-reviews] review granted: [Bug 199632] Remove support for beforeload on link=prefetch : [Attachment 374008] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 15 09:11:10 PDT 2019
youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 199632: Remove support for beforeload on link=prefetch
https://bugs.webkit.org/show_bug.cgi?id=199632
Attachment 374008: Patch
https://bugs.webkit.org/attachment.cgi?id=374008&action=review
--- Comment #21 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 374008
--> https://bugs.webkit.org/attachment.cgi?id=374008
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374008&action=review
> Source/WebCore/html/HTMLLinkElement.cpp:208
> +bool HTMLLinkElement::shouldLoadLink(const LinkLoadParameters& params)
Sorry for my suggestion on the previous patch to do that.
Your initial version seems better.
r=me with shouldLoadLink not taking params.
More information about the webkit-reviews
mailing list