[webkit-reviews] review granted: [Bug 185550] Add referrerpolicy attribute support for <script> elements : [Attachment 370939] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 15 08:57:55 PDT 2019


youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 185550: Add referrerpolicy attribute support for <script> elements
https://bugs.webkit.org/show_bug.cgi?id=185550

Attachment 370939: Patch

https://bugs.webkit.org/attachment.cgi?id=370939&action=review




--- Comment #36 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 370939
  --> https://bugs.webkit.org/attachment.cgi?id=370939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370939&action=review

> Source/WebCore/ChangeLog:36
> +		  http/tests/referrer-policy-script/unsafe-url/same-origin.html

Nice to have all these tests. I guess I should finish the reimport of WPT
referrer policy tests.
I wonder whether some of these might be redundant though or would be worth
exporting to WPT.

> Source/WebCore/bindings/js/CachedScriptFetcher.h:45
> +    CachedScriptFetcher(const String& nonce, const ReferrerPolicy&
referrerPolicy, const String& charset, const AtomicString& initiatorName, bool
isInUserAgentShadowTree)

s/const ReferrerPolicy& policy/ReferrerPolicy

> Source/WebCore/dom/LoadableClassicScript.cpp:38
> +Ref<LoadableClassicScript> LoadableClassicScript::create(const String&
nonce, const String& integrityMetadata, const ReferrerPolicy& policy, const
String& crossOriginMode, const String& charset, const AtomicString&
initiatorName, bool isInUserAgentShadowTree)

Ditto, below as well

> LayoutTests/platform/win/TestExpectations:4299
> +webkit.org/b/195461 http/tests/referrer-policy-script [ Skip ]

Do we know why they are failing here?
I would have thought they would be similar to Mac-wk1.


More information about the webkit-reviews mailing list