[webkit-reviews] review requested: [Bug 199786] Concurrent GC should not rely on current phase to determine if it's safe to steal conn : [Attachment 374094] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has asked  for review:
Bug 199786: Concurrent GC should not rely on current phase to determine if it's
safe to steal conn
https://bugs.webkit.org/show_bug.cgi?id=199786

Attachment 374094: Patch

https://bugs.webkit.org/attachment.cgi?id=374094&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 374094
  --> https://bugs.webkit.org/attachment.cgi?id=374094
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374094&action=review

setting back to r? based on my questions

> Source/JavaScriptCore/heap/Heap.cpp:261
> +	   m_heap.m_collectorThreadIsRunning = false;

Is this the correct place to set this to false? Why are we guaranteed to run
poll() again?