[webkit-reviews] review granted: [Bug 199786] Concurrent GC should not rely on current phase to determine if it's safe to steal conn : [Attachment 374094] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 199786: Concurrent GC should not rely on current phase to determine if it's
safe to steal conn
https://bugs.webkit.org/show_bug.cgi?id=199786

Attachment 374094: Patch

https://bugs.webkit.org/attachment.cgi?id=374094&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 374094
  --> https://bugs.webkit.org/attachment.cgi?id=374094
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374094&action=review

> Source/JavaScriptCore/heap/Heap.cpp:2124
> +    if ((m_lastServedTicket == m_lastGrantedTicket) &&
!m_collectorThreadIsRunning) {

don’t you still need to check m_currentPhase? Can’t that also be driven by the
mutator and we me in the middle of a collection?