[webkit-reviews] review granted: [Bug 199789] [WebGL] Remove software rendering and simplify context creation on macOS : [Attachment 374096] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 199789: [WebGL] Remove software rendering and simplify context creation on
macOS
https://bugs.webkit.org/show_bug.cgi?id=199789

Attachment 374096: Patch

https://bugs.webkit.org/attachment.cgi?id=374096&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 374096
  --> https://bugs.webkit.org/attachment.cgi?id=374096
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374096&action=review

> Source/WebCore/ChangeLog:9
> +	   We don't ever want to fall-back to the software renderer. We'd be
better
> +	   off failing to create the context completely.

Why is this? Why did we support it in the first place?

> Source/WebCore/platform/graphics/GraphicsContext3DManager.cpp:177
> -    ASSERT(m_contexts.contains(context));
> +    if (!m_contexts.contains(context))
> +	   return;

What is this change for?

> Source/WebCore/platform/graphics/GraphicsContext3DManager.cpp:212
> +    if (!context)
> +	   return;

What is this change for?