[webkit-reviews] review granted: [Bug 199744] A Possible Issue of Object.create method : [Attachment 374058] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 12 18:02:58 PDT 2019


Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 199744: A Possible Issue of Object.create method
https://bugs.webkit.org/show_bug.cgi?id=199744

Attachment 374058: Patch

https://bugs.webkit.org/attachment.cgi?id=374058&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 374058
  --> https://bugs.webkit.org/attachment.cgi?id=374058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374058&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:672
> +    JSObject* properties = exec->argument(1).toObject(exec);

Let's use `uncheckedArgument` here.


More information about the webkit-reviews mailing list