[webkit-reviews] review granted: [Bug 199739] Turn off two finger gestures for editable non-scaled content : [Attachment 374057] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 12 18:00:13 PDT 2019
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 199739: Turn off two finger gestures for editable non-scaled content
https://bugs.webkit.org/show_bug.cgi?id=199739
Attachment 374057: Patch
https://bugs.webkit.org/attachment.cgi?id=374057&action=review
--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 374057
--> https://bugs.webkit.org/attachment.cgi?id=374057
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374057&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:793
> + [_twoFingerSingleTapGestureRecognizer setEnabled:!_webView._editable];
I am sold! Though I would probably put it before the add, with all the other
setters.
More information about the webkit-reviews
mailing list