[webkit-reviews] review granted: [Bug 199760] Web Inspector: Changes: dismissing a blank property makes style rule to show in Changes panel : [Attachment 374038] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 199760: Web Inspector: Changes: dismissing a blank property makes style
rule to show in Changes panel
https://bugs.webkit.org/show_bug.cgi?id=199760

Attachment 374038: Patch

https://bugs.webkit.org/attachment.cgi?id=374038&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 374038
  --> https://bugs.webkit.org/attachment.cgi?id=374038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374038&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:443
> +		   this._ownerStyle.updatePropertiesModifiedState();

Why not move this call inside `shiftPropertiesAfter`?  That way, you could
remove the `updatePropertiesModifiedState` on <480 as well.