[webkit-reviews] review granted: [Bug 199741] [iOS WK2] Can't place caret or select in content that overflows a contenteditable element : [Attachment 374028] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 199741: [iOS WK2] Can't place caret or select in content that overflows a
contenteditable element
https://bugs.webkit.org/show_bug.cgi?id=199741

Attachment 374028: Patch

https://bugs.webkit.org/attachment.cgi?id=374028&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 374028
  --> https://bugs.webkit.org/attachment.cgi?id=374028
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374028&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1610
> +    boundingBox.setWidth(boundingBox.width() - style.borderLeftWidth() -
style.borderRightWidth());
> +    boundingBox.setHeight(boundingBox.height() - style.borderBottomWidth() -
style.borderTopWidth());

Nit - could consider using contract instead.

> LayoutTests/editing/caret/ios/caret-in-overflow-area.html:47
> +	   window.addEventListener('load', async () => {
> +	       runTest();
> +	   }, false);

Nit - addEventListener(‘load’, runTest);?

> LayoutTests/editing/selection/ios/place-selection-in-overflow-area.html:53
> +	   window.addEventListener('load', async () => {
> +	       runTest();
> +	   }, false);

Ditto.

>
LayoutTests/editing/selection/ios/selection-extends-into-overflow-area.html:61
> +	   window.addEventListener('load', async () => {
> +	       runTest();
> +	   }, false);

Ditto.