[webkit-reviews] review granted: [Bug 199746] Add API to get all the dependencies of a given JSScript : [Attachment 374020] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 199746: Add API to get all the dependencies of a given JSScript
https://bugs.webkit.org/show_bug.cgi?id=199746

Attachment 374020: Patch

https://bugs.webkit.org/attachment.cgi?id=374020&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 374020
  --> https://bugs.webkit.org/attachment.cgi?id=374020
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374020&action=review

>> Source/JavaScriptCore/ChangeLog:15
>> +	    that didn't start "./" or "/".
> 
> why is that bad? "foo" just just be "./foo", right?

Please describe why we're doing this? E.g, to be compatible with web. And why
the web does it

> Source/JavaScriptCore/ChangeLog:18
> +	   Lastly, this patch makes it so that we copy all scripts in the
API/tests/testapiScripts directory so
> +	   they don't have to be individually added to the xcode project.

👍🏼