[webkit-reviews] review granted: [Bug 194326] [GStreamer] Mock GStreamer realtime sources should keep a Ref of their mock realtime media sources : [Attachment 373932] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 194326: [GStreamer] Mock GStreamer realtime sources should keep a Ref of
their mock realtime media sources
https://bugs.webkit.org/show_bug.cgi?id=194326

Attachment 373932: Patch

https://bugs.webkit.org/attachment.cgi?id=373932&action=review




--- Comment #22 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 373932
  --> https://bugs.webkit.org/attachment.cgi?id=373932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373932&action=review

>
Source/WebCore/platform/mediastream/gstreamer/MockGStreamerAudioCaptureSource.h
:43
>      void videoSampleAvailable(MediaSample&) override { };

Should probably be final as well.

>
Source/WebCore/platform/mediastream/gstreamer/MockGStreamerVideoCaptureSource.h
:48
>      void videoSampleAvailable(MediaSample&) override;

Ditto.