[webkit-reviews] review granted: [Bug 199625] [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF : [Attachment 373927] Replacing HAVE(ACCESSIBILITY) with ENABLE(ACCESSIBILITY)

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 199625: [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
https://bugs.webkit.org/show_bug.cgi?id=199625

Attachment 373927: Replacing HAVE(ACCESSIBILITY) with ENABLE(ACCESSIBILITY)

https://bugs.webkit.org/attachment.cgi?id=373927&action=review




--- Comment #30 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373927
  --> https://bugs.webkit.org/attachment.cgi?id=373927
Replacing HAVE(ACCESSIBILITY) with ENABLE(ACCESSIBILITY)

View in context: https://bugs.webkit.org/attachment.cgi?id=373927&action=review

Also, in OptionsPlayStation.cmake, remove:

# Temporarily turn off Accessibility support
SET_AND_EXPOSE_TO_BUILD(HAVE_ACCESSIBILITY OFF)

and add:

WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE OFF)

>> Source/WTF/ChangeLog:6
>> +	    Added ENABLE(ACCESSIBILITY)
> 
> Sentences
> Which are not terminated with periods
> Look weird

Indeed.

> Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:403
> +    my $conditionalString =
$$self{codeGenerator}->GenerateConditionalString($interface);
> +    unshift(@contents, "\n#if ${conditionalString}\n\n") if
$conditionalString;

Ah wow, good fix. I didn't even realize there was a separate
CodeGeneratorTestRunner.pm script!

> ChangeLog:8
> +	   Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
> +	   with ENABLE(ACCESSIBILITY) in the code
> +	   The TestRunner code generator honors the Conditional IDL format

So yeah, as Konstantin said, please write this out as a normal paragraph:

Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
with ENABLE(ACCESSIBILITY) in the code.

Additionally, the TestRunner code generator now honors the
Conditional IDL format.