[webkit-reviews] review granted: [Bug 199555] Web Inspector: Layers: Uncaught Exception: Request with id = 2 failed. {"code":-32601, "message":"'Page' domain was not found", "data":[{"code":-32601, "message":"'Page' domain was not found"}]} : [Attachment 373674] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 199555: Web Inspector: Layers: Uncaught Exception: Request with id = 2
failed. {"code":-32601,"message":"'Page' domain was not
found","data":[{"code":-32601,"message":"'Page' domain was not found"}]}
https://bugs.webkit.org/show_bug.cgi?id=199555

Attachment 373674: Patch

https://bugs.webkit.org/attachment.cgi?id=373674&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 373674
  --> https://bugs.webkit.org/attachment.cgi?id=373674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373674&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:639
> +		  target.PageAgent.setShowPaintRects(activated);

Whitespace is still wrong here.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:660
> +		  target.PageAgent.setEmulatedMedia(mediaType);

Whitespace is still wrong here.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:741
> +	   for (let target of WI.targets) {

Style: Put a newline before this?

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:398
> +	   for (let target of WI.targets) {

Style: Put a newline before this?

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:400
> +		  target.PageAgent.setShowPaintRects(activated);

Whitespace is still wrong here.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:433
> +	   for (let target of WI.targets) {

Style: Put a newline before this?