[webkit-reviews] review granted: [Bug 199696] Long pressing on attachments will crash the WebContent process : [Attachment 373890] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 10 18:56:17 PDT 2019


Dean Jackson <dino at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 199696: Long pressing on attachments will crash the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=199696

Attachment 373890: Patch

https://bugs.webkit.org/attachment.cgi?id=373890&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 373890
  --> https://bugs.webkit.org/attachment.cgi?id=373890
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373890&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2667
> +	   linkIndicatorPositionInformation(page, attachment, request, info);

Less than perfect name for a function (there are many like this in the file).


More information about the webkit-reviews mailing list