[webkit-reviews] review granted: [Bug 199693] [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content : [Attachment 373882] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 199693: [iOS WK2] With modal overlay and body overflow:hidden, can't access
all the content
https://bugs.webkit.org/show_bug.cgi?id=199693

Attachment 373882: Patch

https://bugs.webkit.org/attachment.cgi?id=373882&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 373882
  --> https://bugs.webkit.org/attachment.cgi?id=373882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373882&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2029
> +    bool scrollingNeededToRevealUI = false;

I don't know that this is the best name (nor do I love the changelog wording).
Could be more abstractly worded.

> Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

alas, it is not 2018. it's barely even 2019 anymore