[webkit-reviews] review denied: [Bug 199625] [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF : [Attachment 373848] patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 199625: [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
https://bugs.webkit.org/show_bug.cgi?id=199625

Attachment 373848: patch

https://bugs.webkit.org/attachment.cgi?id=373848&action=review




--- Comment #20 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373848
  --> https://bugs.webkit.org/attachment.cgi?id=373848
patch

OK, HAVE(ACCESSIBILITY) is valid on all ports in the code itself, after
including Platform.h, which is good. But at the CMake level it only exists for
PlayStation (where it's set to OFF) and WPE ports. So again, this will break
everything except WPE. There is no way to do this at the CMake level without
introducing a new variable that's defined on all platforms. We could e.g. add
ENABLE_ACCESSIBILITY to WebKitFeatures.cmake and then use  if
(ENABLE_ACCESSIBILITY) here. That would be OK.

Of course the ideal solution would be to debug the linker error and get this
working using only guards in the files themselves, but I understand that's
hard.