[webkit-reviews] review granted: [Bug 199662] [iOS] REGRESSION(r244851): Revealing caret sometimes fails when content inset is used : [Attachment 373825] Fixes the bug

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 199662: [iOS] REGRESSION(r244851): Revealing caret sometimes fails when
content inset is used
https://bugs.webkit.org/show_bug.cgi?id=199662

Attachment 373825: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=373825&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 373825
  --> https://bugs.webkit.org/attachment.cgi?id=373825
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=373825&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2685
>	       LayoutRect viewRect =
frameView.visualViewportRectExpandedByContentInsets();
>  
> +	       maxScrollPosition =
frameView.scrollPositionFromOffset(ScrollPosition(frameView.totalContentsSize()
- flooredIntSize(viewRect.size())));

We need to clean this up so that webcore code doesn't have to get muddied with
inset complexity.