[webkit-reviews] review granted: [Bug 198979] Allow CMake to build WebCore on Mac : [Attachment 373803] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 10 11:43:18 PDT 2019


Don Olmstead <don.olmstead at sony.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 198979: Allow CMake to build WebCore on Mac
https://bugs.webkit.org/show_bug.cgi?id=198979

Attachment 373803: patch

https://bugs.webkit.org/attachment.cgi?id=373803&action=review




--- Comment #15 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 373803
  --> https://bugs.webkit.org/attachment.cgi?id=373803
patch

r=me

Anyways you can make your decision on where to put headers and derived sources
but I would recommend overriding it so things work more like an XCode build.


More information about the webkit-reviews mailing list