[webkit-reviews] review granted: [Bug 199675] [WHLSL] Track code locations correctly throughout the compiler to get good error messages : [Attachment 373851] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 199675: [WHLSL] Track code locations correctly throughout the compiler to
get good error messages
https://bugs.webkit.org/show_bug.cgi?id=199675

Attachment 373851: Patch

https://bugs.webkit.org/attachment.cgi?id=373851&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 373851
  --> https://bugs.webkit.org/attachment.cgi?id=373851
Patch

Now that we’re downgrading string indexes to 32-bits, can we do an early check
that the string isn’t too long, and early-out if it is?

Also, because there’s no ChangeLog, it isn’t clear what you were hoping to
accomplish with this patch. Because there’s not really a behavior change,
please include some results in the ChangeLog (performance results, or memory
size reduction, etc.).

r=me assuming you do that.