[webkit-reviews] review denied: [Bug 199625] [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF : [Attachment 373828] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 10 08:01:06 PDT 2019
Michael Catanzaro <mcatanzaro at igalia.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 199625: [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
https://bugs.webkit.org/show_bug.cgi?id=199625
Attachment 373828: patch
https://bugs.webkit.org/attachment.cgi?id=373828&action=review
--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373828
--> https://bugs.webkit.org/attachment.cgi?id=373828
patch
Again, this is r- because ENABLE_ACCESSIBILITY is only defined for WPE. I'm
really surprised this only broke the WinCairo EWS. The GTK EWS doesn't run
tests, so maybe we wouldn't notice the accessibility layout tests failing until
this lands.
Fujii, what do you think? I'm OK with replacing HAVE(ACCESSIBILITY) with
ENABLE(ACCESSIBILITY).
More information about the webkit-reviews
mailing list