[webkit-reviews] review granted: [Bug 198997] Add StringBuilder member function which allows makeString() style variadic argument construction : [Attachment 373774] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 198997: Add StringBuilder member function which allows makeString() style
variadic argument construction
https://bugs.webkit.org/show_bug.cgi?id=198997

Attachment 373774: Patch

https://bugs.webkit.org/attachment.cgi?id=373774&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 373774
  --> https://bugs.webkit.org/attachment.cgi?id=373774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373774&action=review

> Source/WTF/wtf/text/StringBuilder.h:235
> +    template<typename... StringTypes>
> +    void flexibleAppend(StringTypes ...strings);

// FIXME: Rename to append after renaming any overloads of append that take
more than one argument.

Also, consider doing in a single line? Also, can we omit the argument name
"strings" here? I don’t think it adds anything.

> Source/WTF/wtf/text/StringBuilder.h:356
> +    template <typename CharType> void reallocateBuffer(unsigned
requiredLength);

My preferred formatting for this:

    template<typename CharacterType> void reallocationBuffer(unsigned
requiredLength);

(similar for below)

> Source/WTF/wtf/text/StringBuilder.h:369
> +    template<typename... StringTypeAdapters>
> +    void flexibleAppendFromAdapters(StringTypeAdapters ...adapters);

Consider doing in a single line? Also, can we omit the argument name "adapters"
here? I don’t think it adds anything.