[webkit-reviews] review granted: [Bug 199636] Optimize join of large empty arrays : [Attachment 373772] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 9 15:10:53 PDT 2019

Mark Lam <mark.lam at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 199636: Optimize join of large empty arrays

Attachment 373772: Patch


--- Comment #15 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 373772
  --> https://bugs.webkit.org/attachment.cgi?id=373772

View in context: https://bugs.webkit.org/attachment.cgi?id=373772&action=review

r=me with fix.

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:521
> +	       if (!length)

This should be length <= 1.  If length == 1, it should also produce an empty
string (nothing to separator).

More information about the webkit-reviews mailing list