[webkit-reviews] review denied: [Bug 199636] Optimize join of large empty arrays : [Attachment 373745] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied  review:
Bug 199636: Optimize join of large empty arrays
https://bugs.webkit.org/show_bug.cgi?id=199636

Attachment 373745: Patch

https://bugs.webkit.org/attachment.cgi?id=373745&action=review




--- Comment #13 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 373745
  --> https://bugs.webkit.org/attachment.cgi?id=373745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373745&action=review

>>>> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:522
>>>> +		  unsigned count = length - 1;
>>> 
>>> Do we need `length == 0` handling?
>> 
>> This is already handled in "case 0:" above.
> 
> I think `case 0:` is for separator.length (separator string's length). And
this "length" is length of array.

Oops.  Sorry I missed that.