[webkit-reviews] review granted: [Bug 199637] [iOS WK2] Use Optional<> for two data members of WKWebView : [Attachment 373751] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 9 13:29:59 PDT 2019
Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 199637: [iOS WK2] Use Optional<> for two data members of WKWebView
https://bugs.webkit.org/show_bug.cgi?id=199637
Attachment 373751: Patch
https://bugs.webkit.org/attachment.cgi?id=373751&action=review
--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 373751
--> https://bugs.webkit.org/attachment.cgi?id=373751
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=373751&action=review
> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:6310
> + _viewLayoutSizeOverride = WTF::nullopt;
> + _maximumUnobscuredSizeOverride = WTF::nullopt;
.clear()? 🤷♂️
More information about the webkit-reviews
mailing list