[webkit-reviews] review denied: [Bug 199625] [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF : [Attachment 373749] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 9 13:26:18 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 199625: [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF

Attachment 373749: patch


--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373749
  --> https://bugs.webkit.org/attachment.cgi?id=373749

No I mean in the files themselves. E.g. AccessibilityController.cpp already has
an #if HAVE(ACCESSIBILITY) guard, but AccessibilityController.h is missing the
guard. (Instead the header has some internal guards, which is really weird. I
would try removing those.)

More information about the webkit-reviews mailing list