[webkit-reviews] review denied: [Bug 199625] [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF : [Attachment 373730] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 9 13:07:39 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 199625: [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF

Attachment 373730: patch


--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373730
  --> https://bugs.webkit.org/attachment.cgi?id=373730

It doesn't need to be reverted. Just guard all the files with #if
HAVE(ACCESSIBILITY). Let's try to build files unconditionally at the CMake
level and use guards in the files instead whenever we can.

More information about the webkit-reviews mailing list