[webkit-reviews] review granted: [Bug 199626] Fix non thread-safe use of WeakPtr in DisplayRefreshMonitorMac::displayLinkFired() : [Attachment 373731] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199626: Fix non thread-safe use of WeakPtr in
DisplayRefreshMonitorMac::displayLinkFired()
https://bugs.webkit.org/show_bug.cgi?id=199626

Attachment 373731: Patch

https://bugs.webkit.org/attachment.cgi?id=373731&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 373731
  --> https://bugs.webkit.org/attachment.cgi?id=373731
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373731&action=review

Maybe we need ThreadSafeWeakPtr...

> Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.h:46
>      void displayLinkFired() override;

This does class need to inherit from CanMakeWeakPtr now?