[webkit-reviews] review denied: [Bug 199454] [PlayStation] Add Buildbots for Debug/Release builds : [Attachment 373691] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 9 04:12:13 PDT 2019

Aakash Jain <aakash_jain at apple.com> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 199454: [PlayStation] Add Buildbots for Debug/Release builds

Attachment 373691: Patch


--- Comment #2 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 373691
  --> https://bugs.webkit.org/attachment.cgi?id=373691

View in context: https://bugs.webkit.org/attachment.cgi?id=373691&action=review

Schedulers seems to be missing for PlayStation builders. Without that 'buildbot
checkconfig' should fail. r- due to that.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:86
> +		       { "name": "playstation-debug-build-01", "platform":
"playstation" }

Nit: might be a good idea to move this section next to wincairo bots so that
all the sony bots are mentioned together.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:360
> +		       },

Nit: ditto about moving above next to wincairo section.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:362
> +			 "name": "PlayStation Debug (Build)", "type": "Build",
"builddir": "build",

ilddir says "Each builder must have a unique build directory.". same for old
Buildbot (e.g.: http://docs.buildbot.net/0.8.1/Builders.html)

It seems it's better to either remove 'builddir' (to use the default) or
specify a unique builddir.

> Tools/ChangeLog:10
> +	   (BuildBotConfigLoader._add_dependent_modules_to_sys_modules):

This method doesn't seems to be modified in this patch, probably a bug in
prepare-ChangeLog, please delete this line.

More information about the webkit-reviews mailing list