[webkit-reviews] review granted: [Bug 199552] Web Inspector: DOM Debugger: there should be different icons for each type of DOM breakpoint : [Attachment 373574] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 199552: Web Inspector: DOM Debugger: there should be different icons for
each type of DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=199552

Attachment 373574: Patch

https://bugs.webkit.org/attachment.cgi?id=373574&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 373574
  --> https://bugs.webkit.org/attachment.cgi?id=373574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373574&action=review

r=me

> Source/WebInspectorUI/UserInterface/Images/DOMBreakpointSubtreeModified.svg:6
> +    <path fill="rgb(113, 146, 184)" d="M 5.19849793 12.6584609 C 5.2831472
12.676395 6.98277851 12.9487305 7.62939453 12.9487305 C 8.79640591 12.9487305
9.76331344 12.6806542 10.5034462 12.1146703 C 11.3037555 11.5026691 11.7177734
10.6286312 11.7177734 9.58544922 C 11.7177734 8.84534902 11.4998181 8.18341061
11.0628295 7.63852362 C 10.6767371 7.15709971 10.0557113 6.69185669 9.18734192
6.20492057 L 8.61524891 5.88648574 C 8.27558142 5.69523066 8.15431716
5.69238281 8.23632812 5.69238281 C 8.56703836 5.69238281 9.10333246 5.81936052
9.8138795 6.08542439 L 11.1645508 6.59118236 L 11.1645508 5.14892578 L
11.1645508 3.87597656 L 11.1645508 3.07965768 L 10.3884483 2.90136387 C
9.52406853 2.70279014 8.73593121 2.60205078 8.02148438 2.60205078 C 7.01081351
2.60205078 6.14909735 2.87110984 5.47554965 3.42697448 C 4.76046595 4.01711791
4.38964844 4.82767811 4.38964844 5.77734375 C 4.38964844 6.49239045 4.61205052
7.14196725 5.04920932 7.68841575 C 5.43639142 8.17239338 6.03437082 8.62885808
6.84888633 9.08727887 L 7.38545082 9.38538774 C 7.71699471 9.57330366
7.92926232 9.72631865 7.99164827 9.79813503 C 7.94460492 9.81851991 7.82252674
9.85302734 7.60253906 9.85302734 C 7.14294036 9.85302734 6.53493744 9.70437137
5.79174704 9.39341305 L 4.40576172 8.81350287 L 4.40576172 10.315918 L
4.40576172 11.6801758 L 4.40576172 12.4905083 L 5.19849793 12.6584609 C
5.52713094 12.7280865 5.52713094 12.7280865 5.57407851 12.738033 L 5.19849793
12.6584609 Z M 5.19849793 12.6584609"/>

We should really consider reducing the significant figures. This is a 16x16
(32x32 on @2x) icon.