[webkit-reviews] review granted: [Bug 199596] Null check HistoryItems given to loadDifferentDocumentItem : [Attachment 373675] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 8 19:55:46 PDT 2019

Ryosuke Niwa <rniwa at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 199596: Null check HistoryItems given to loadDifferentDocumentItem

Attachment 373675: Patch


--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 373675
  --> https://bugs.webkit.org/attachment.cgi?id=373675

View in context: https://bugs.webkit.org/attachment.cgi?id=373675&action=review

> Source/WebCore/loader/FrameLoader.cpp:3874
> +    if (item)

Should we add a debug assertion / release logging when item is null?

More information about the webkit-reviews mailing list