[webkit-reviews] review granted: [Bug 199591] Use WeakHashSet for WebUserContentControllerProxy::m_processes : [Attachment 373672] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 8 16:05:56 PDT 2019
youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199591: Use WeakHashSet for WebUserContentControllerProxy::m_processes
https://bugs.webkit.org/show_bug.cgi?id=199591
Attachment 373672: Patch
https://bugs.webkit.org/attachment.cgi?id=373672&action=review
--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 373672
--> https://bugs.webkit.org/attachment.cgi?id=373672
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=373672&action=review
> Source/WebKit/ChangeLog:10
> + stay in the map if we failed to call WebProcessProxy::shutDown()
before destroying it.
Since we are trying to add/remove the entries in the map properly, should we
add some debug asserts that we are actually doing this correctly?
More information about the webkit-reviews
mailing list