[webkit-reviews] review denied: [Bug 198029] Web Inspector: Display "Resource has no content" for about:blank iframes instead of an error : [Attachment 373590] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 198029: Web Inspector: Display "Resource has no content" for about:blank
iframes instead of an error
https://bugs.webkit.org/show_bug.cgi?id=198029

Attachment 373590: Patch

https://bugs.webkit.org/attachment.cgi?id=373590&action=review




--- Comment #14 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 373590
  --> https://bugs.webkit.org/attachment.cgi?id=373590
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373590&action=review

r-, due to the following:

> Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:139
> +	       this.showGenericNoContentMessage();

After talking with @Joe, we agreed that it actually probably should just show
"about:blank" as a message.  The reasoning for this is that <about:blank> is
this kinda special "resource" that doesn't actually go over the network, but
has this "implicit" concept of "this is an empty resource".  Along these lines,
we also agreed that resources requested over the network that have no content
(including <data:text/html,>) should show as an empty text editor, not
"Resource has no content".  The only time that we should show that message (if
ever) is if somehow we no longer have the content (e.g. the resource cache ran
out of room).

Sorry for the back and forth :(