[webkit-reviews] review granted: [Bug 199581] Hop explicitly to the main thread after generating a frame in ScreenDisplayCaptureSourceMac : [Attachment 373648] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 8 14:15:47 PDT 2019


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 199581: Hop explicitly to the main thread after generating a frame in
ScreenDisplayCaptureSourceMac
https://bugs.webkit.org/show_bug.cgi?id=199581

Attachment 373648: Patch

https://bugs.webkit.org/attachment.cgi?id=373648&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 373648
  --> https://bugs.webkit.org/attachment.cgi?id=373648
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373648&action=review

> Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:169
> +		   weakThis->newFrame(status, WTFMove(frame));

There isn't a lot of code in newFrame now, it might make sense to move it here.


More information about the webkit-reviews mailing list