[webkit-reviews] review denied: [Bug 199489] run-javascript-core-test won't report json results for testmasm, testair, testb3, testdfg and test api : [Attachment 373451] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has denied Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 199489: run-javascript-core-test won't report json results for testmasm,
testair, testb3, testdfg and test api
https://bugs.webkit.org/show_bug.cgi?id=199489

Attachment 373451: Patch

https://bugs.webkit.org/attachment.cgi?id=373451&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 373451
  --> https://bugs.webkit.org/attachment.cgi?id=373451
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373451&action=review

> Tools/Scripts/run-javascriptcore-tests:-406
> -    if ($testResult && $failFast) {

Why is testResult being removed from here? Doesn't that mean that irrespective
of failure or success, we will always exit the script. 
Since the runTest() method is called multiple times (once each for testmasm,
testair, testb3, testdfg, testapi), only 'testmasm' would be run, and rest of
the tests would never be run.

Please verify.