[webkit-reviews] review granted: [Bug 199572] REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the DNS cache landed : [Attachment 373625] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 199572: REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the
DNS cache landed
https://bugs.webkit.org/show_bug.cgi?id=199572

Attachment 373625: Patch

https://bugs.webkit.org/attachment.cgi?id=373625&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373625
  --> https://bugs.webkit.org/attachment.cgi?id=373625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373625&action=review

Score +1 for valgrind

> Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp:111
> -	       g_task_return_error(task.get(), error.get());
> +	       g_task_return_error(task.get(), error);

My preference is to keep using GUniqueOutPtr -- so that we never hold ownership
in a raw pointer -- and use error.release() here instead. But this is fine too.

> Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp:173
> -	       g_task_return_error(task.get(), error.get());
> +	       g_task_return_error(task.get(), error);

Ditto.