[webkit-reviews] review granted: [Bug 199541] switch(String) needs to check for exceptions when resolving the string : [Attachment 373560] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 199541: switch(String) needs to check for exceptions when resolving the
string
https://bugs.webkit.org/show_bug.cgi?id=199541

Attachment 373560: Patch

https://bugs.webkit.org/attachment.cgi?id=373560&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 373560
  --> https://bugs.webkit.org/attachment.cgi?id=373560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373560&action=review

r=me with throwScope declaration fix.

> Source/JavaScriptCore/dfg/DFGOperations.cpp:2478
>  

nit: can you remove this empty line?

> Source/JavaScriptCore/jit/JITOperations.cpp:2320
> +	   auto throwScope = DECLARE_THROW_SCOPE(vm);

You should declare this at the top of the function at the earliest possible
location.  This is the recommended best practice unless there's a really good
reason not to.