[webkit-reviews] review granted: [Bug 199537] [WHLSL] The checker does not need to keep a separate m_typeAnnotations map : [Attachment 373554] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 199537: [WHLSL] The checker does not need to keep a separate
m_typeAnnotations map
https://bugs.webkit.org/show_bug.cgi?id=199537

Attachment 373554: Patch

https://bugs.webkit.org/attachment.cgi?id=373554&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 373554
  --> https://bugs.webkit.org/attachment.cgi?id=373554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373554&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:-845
> -    if (leftInfo->typeAnnotation.isRightValue()) {
> -	   setError();
> -	   return;
> -    }

Why? This seems important.