[webkit-reviews] review granted: [Bug 199503] [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition : [Attachment 373474] Fixes the bug

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 199503: [iOS] Crash in WebKit::WebPage::positionInformation via
Range::startPosition
https://bugs.webkit.org/show_bug.cgi?id=199503

Attachment 373474: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=373474&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 373474
  --> https://bugs.webkit.org/attachment.cgi?id=373474
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=373474&action=review

LGTM, with a build fix for macOS.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:551
> +- (void)_ensurePositionInformationAt:(CGPoint)location completion:(void
(^)(void))updateBlock WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

This seems identical to -[WKWebView
_requestActivatedElementAtPosition:completionBlock:], except it’s sync instead
of async.

Do we need to make a sync position info request for this test, or can we have
UIScriptController piggy-back off of the existing
_requestActivatedElementAtPosition:completionBlock: SPI in WKWebViewPrivate.h?