[webkit-reviews] review granted: [Bug 199498] Scribble Heap::m_worldState on destructor : [Attachment 373465] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 4 15:24:32 PDT 2019
Sam Weinig <sam at webkit.org> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 199498: Scribble Heap::m_worldState on destructor
https://bugs.webkit.org/show_bug.cgi?id=199498
Attachment 373465: Patch
https://bugs.webkit.org/attachment.cgi?id=373465&action=review
--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 373465
--> https://bugs.webkit.org/attachment.cgi?id=373465
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=373465&action=review
> Source/JavaScriptCore/heap/Heap.cpp:342
> + m_worldState.store(0xbadbeef0u);
I think a comment here clarifying why this store is being made would be
instructive.
More information about the webkit-reviews
mailing list