[webkit-reviews] review denied: [Bug 199469] HyphenationLibHyphen: Include GLib-related headers only if ENABLE(DEVELOPER_MODE) is true : [Attachment 373447] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 199469: HyphenationLibHyphen: Include GLib-related headers only if
ENABLE(DEVELOPER_MODE) is true
https://bugs.webkit.org/show_bug.cgi?id=199469

Attachment 373447: Patch

https://bugs.webkit.org/attachment.cgi?id=373447&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373447
  --> https://bugs.webkit.org/attachment.cgi?id=373447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373447&action=review

> Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp:43
> +#if ENABLE(DEVELOPER_MODE) && PLATFORM(GTK)

Well this is even worse, now they won't work for WPE layout tests, right?

If you're using USE(GLIB) then what's the problem with including these headers?