[webkit-reviews] review granted: [Bug 199483] Test freshness page should expose revision information for latest build on tooltip. : [Attachment 373442] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 199483: Test freshness page should expose revision information for latest
build on tooltip.
https://bugs.webkit.org/show_bug.cgi?id=199483

Attachment 373442: Patch

https://bugs.webkit.org/attachment.cgi?id=373442&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 373442
  --> https://bugs.webkit.org/attachment.cgi?id=373442
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373442&action=review

> Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:94
> +		       let commitSet = null;

commitSetOfLastPoint?

> Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js:178
> +	   for (const repository of
Repository.sortByNamePreferringOnesWithURL(commitSet.repositories())) {
> +	       const commit = commitSet.commitForRepository(repository);
> +	       tableContent.push(element('tr', [

Better written as:
tableContent.push(Repository.sortByNamePreferringOnesWithURL(commitSet.reposito
ries()).map((repository) => {
    ~
});
Note: CommonComponentBase._addContentToElement would unwrap nested arrays.