[webkit-reviews] review granted: [Bug 199474] [WHLSL] Remove the phase resolveCallsInFunctions : [Attachment 373439] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 17:14:10 PDT 2019

Myles C. Maxfield <mmaxfield at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 199474: [WHLSL] Remove the phase resolveCallsInFunctions

Attachment 373439: Patch


--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 373439
  --> https://bugs.webkit.org/attachment.cgi?id=373439

View in context: https://bugs.webkit.org/attachment.cgi?id=373439&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:1028
> +	   getterFunction = resolveFunction(m_program, getterFunctions,
getterArgumentTypes, getterName, propertyAccessExpression.origin(),

nit: if ((getterFunction = resolveFunction(...))

More information about the webkit-reviews mailing list