[webkit-reviews] review granted: [Bug 198269] Implement MappedFileData for Windows : [Attachment 373420] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 15:20:36 PDT 2019

Darin Adler <darin at apple.com> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 198269: Implement MappedFileData for Windows

Attachment 373420: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 373420
  --> https://bugs.webkit.org/attachment.cgi?id=373420

View in context: https://bugs.webkit.org/attachment.cgi?id=373420&action=review

> Source/WTF/wtf/FileSystem.cpp:277
> +#if HAVE(MMAP)

Should have a blank line after this.

> Source/WTF/wtf/FileSystem.cpp:326
> +#endif

Should have a blank line before this.

> Source/WTF/wtf/FileSystem.h:36
> +#include <wtf/Noncopyable.h>

See comment below.

> Source/WTF/wtf/FileSystem.h:196
> +    WTF_MAKE_NONCOPYABLE(MappedFileData);

Given my understanding of C++, this should not be necessary. Defining a move
constructor and a move assignment operator as this class does should implicitly
cause the copy constructor and copy assignment operator to not be generated. So
there should be no additional need to use WTF_MAKE_NOCOPYABLE.

Was there some concrete problem that this fixed on Windows? Maybe my
understanding of C++ is wrong, or maybe this works around a bug in the Windows
C++ compiler.

I’d prefer to not make the change unless it’s required.

More information about the webkit-reviews mailing list