[webkit-reviews] review granted: [Bug 199209] [Catalina] Enable WebKit build : [Attachment 373418] patch-8

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jonathan Bedard <jbedard at apple.com>'s
request for review:
Bug 199209: [Catalina] Enable WebKit build
https://bugs.webkit.org/show_bug.cgi?id=199209

Attachment 373418: patch-8

https://bugs.webkit.org/attachment.cgi?id=373418&action=review




--- Comment #25 from Darin Adler <darin at apple.com> ---
Comment on attachment 373418
  --> https://bugs.webkit.org/attachment.cgi?id=373418
patch-8

View in context: https://bugs.webkit.org/attachment.cgi?id=373418&action=review

> Source/WTF/ChangeLog:9
> +	   * wtf/spi/cocoa/SecuritySPI.h: Ensure that we define
SecTrustedApplicationCreateFromPath before
> +	   other headers declare it unavailable on Mac.

I don’t think "before" is correct in this change log comment. There’s no
ordering issue. We prevent it from being defined as unavailable with a
different technique, it’s not about ordering.